From f28af62c5e4fea219ceee0b4f88a1cb267cd39e4 Mon Sep 17 00:00:00 2001 From: Darin Kelkhoff Date: Tue, 21 Feb 2023 22:19:50 -0600 Subject: [PATCH] Update insert action to do pre-step - e.g., to prime amazon s3 client --- .../base/actions/AbstractBaseFilesystemAction.java | 2 ++ .../module/filesystem/s3/actions/S3InsertActionTest.java | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java b/qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java index 1c255254..91ec2b03 100644 --- a/qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java +++ b/qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java @@ -338,6 +338,8 @@ public abstract class AbstractBaseFilesystemAction { try { + preAction(insertInput.getBackend()); + InsertOutput output = new InsertOutput(); QTableMetaData table = insertInput.getTable(); QBackendMetaData backend = insertInput.getBackend(); diff --git a/qqq-backend-module-filesystem/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/actions/S3InsertActionTest.java b/qqq-backend-module-filesystem/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/actions/S3InsertActionTest.java index b7f2da69..ff45ff9a 100644 --- a/qqq-backend-module-filesystem/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/actions/S3InsertActionTest.java +++ b/qqq-backend-module-filesystem/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/actions/S3InsertActionTest.java @@ -25,7 +25,6 @@ package com.kingsrook.qqq.backend.module.filesystem.s3.actions; import java.io.IOException; import java.util.List; import com.amazonaws.services.s3.model.S3Object; -import com.kingsrook.qqq.backend.core.actions.tables.InsertAction; import com.kingsrook.qqq.backend.core.exceptions.QException; import com.kingsrook.qqq.backend.core.model.actions.tables.insert.InsertInput; import com.kingsrook.qqq.backend.core.model.actions.tables.insert.InsertOutput; @@ -89,7 +88,11 @@ public class S3InsertActionTest extends BaseS3Test insertInput.setRecords(List.of( new QRecord().withValue("id", "1").withValue("firstName", "Bob") )); - assertThatThrownBy(() -> new InsertAction().execute(insertInput)) + + S3InsertAction insertAction = new S3InsertAction(); + insertAction.setS3Utils(getS3Utils()); + + assertThatThrownBy(() -> insertAction.execute(insertInput)) .hasRootCauseInstanceOf(NotImplementedException.class); } } \ No newline at end of file