QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-18 13:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

CE-882 Better error on unique key violation

Browse Source
This commit is contained in:
darin.kelkhoff
2024-04-28 20:29:50 -05:00
parent 389e7a1515
commit ea28c007c1
1 changed files with 28 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/sharing/InsertSharedRecordProcess.java
View File

@ -24,6 +24,7 @@ package com.kingsrook.qqq.backend.core.processes.implementations.sharing;
import java.io.Serializable; import java.io.Serializable;
import java.util.List; import java.util.List;
import java.util.Map;
import java.util.Objects; import java.util.Objects;
import com.kingsrook.qqq.backend.core.actions.processes.BackendStep; import com.kingsrook.qqq.backend.core.actions.processes.BackendStep;
import com.kingsrook.qqq.backend.core.actions.tables.GetAction; import com.kingsrook.qqq.backend.core.actions.tables.GetAction;
@ -54,6 +55,7 @@ import com.kingsrook.qqq.backend.core.model.metadata.sharing.ShareableTableMetaD
import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData; import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData;
import com.kingsrook.qqq.backend.core.model.metadata.tables.TablesPossibleValueSourceMetaDataProvider; import com.kingsrook.qqq.backend.core.model.metadata.tables.TablesPossibleValueSourceMetaDataProvider;
import com.kingsrook.qqq.backend.core.model.statusmessages.BadInputStatusMessage; import com.kingsrook.qqq.backend.core.model.statusmessages.BadInputStatusMessage;
import com.kingsrook.qqq.backend.core.model.statusmessages.DuplicateKeyBadInputStatusMessage;
import com.kingsrook.qqq.backend.core.model.statusmessages.QErrorMessage; import com.kingsrook.qqq.backend.core.model.statusmessages.QErrorMessage;
import com.kingsrook.qqq.backend.core.utils.CollectionUtils; import com.kingsrook.qqq.backend.core.utils.CollectionUtils;
import com.kingsrook.qqq.backend.core.utils.StringUtils; import com.kingsrook.qqq.backend.core.utils.StringUtils;
@ -113,6 +115,7 @@ public class InsertSharedRecordProcess implements BackendStep, MetaDataProducerI
Objects.requireNonNull(audienceIdString, "Missing required input: audienceId"); Objects.requireNonNull(audienceIdString, "Missing required input: audienceId");
Objects.requireNonNull(scopeId, "Missing required input: scopeId"); Objects.requireNonNull(scopeId, "Missing required input: scopeId");
String assetTableLabel = tableName;
try try
{ {
SharedRecordProcessUtils.AssetTableAndRecord assetTableAndRecord = SharedRecordProcessUtils.getAssetTableAndRecord(tableName, recordIdString); SharedRecordProcessUtils.AssetTableAndRecord assetTableAndRecord = SharedRecordProcessUtils.getAssetTableAndRecord(tableName, recordIdString);
@ -120,6 +123,7 @@ public class InsertSharedRecordProcess implements BackendStep, MetaDataProducerI
ShareableTableMetaData shareableTableMetaData = assetTableAndRecord.shareableTableMetaData(); ShareableTableMetaData shareableTableMetaData = assetTableAndRecord.shareableTableMetaData();
QRecord assetRecord = assetTableAndRecord.record(); QRecord assetRecord = assetTableAndRecord.record();
Serializable recordId = assetTableAndRecord.recordId(); Serializable recordId = assetTableAndRecord.recordId();
assetTableLabel = assetTableAndRecord.table().getLabel();
SharedRecordProcessUtils.assertRecordOwnership(shareableTableMetaData, assetRecord, "share"); SharedRecordProcessUtils.assertRecordOwnership(shareableTableMetaData, assetRecord, "share");
@ -135,12 +139,26 @@ public class InsertSharedRecordProcess implements BackendStep, MetaDataProducerI
/////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////
// if we know the audience source-table, then fetch & validate security-wise the audience id // // if we know the audience source-table, then fetch & validate security-wise the audience id //
/////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////
Serializable audienceId = audienceIdString; Serializable audienceId = audienceIdString;
String audienceTableLabel = "audience";
if(StringUtils.hasContent(shareableAudienceType.getSourceTableName())) if(StringUtils.hasContent(shareableAudienceType.getSourceTableName()))
{ {
QTableMetaData audienceTable = QContext.getQInstance().getTable(shareableAudienceType.getSourceTableName()); QTableMetaData audienceTable = QContext.getQInstance().getTable(shareableAudienceType.getSourceTableName());
audienceId = ValueUtils.getValueAsFieldType(audienceTable.getField(audienceTable.getPrimaryKeyField()).getType(), audienceIdString); audienceTableLabel = audienceTable.getLabel();
QRecord audienceRecord = new GetAction().executeForRecord(new GetInput(audienceTable.getName()).withPrimaryKey(audienceId));
GetInput getInput = new GetInput(audienceTable.getName());
if(StringUtils.hasContent(shareableAudienceType.getSourceTableKeyFieldName()))
{
audienceId = ValueUtils.getValueAsFieldType(audienceTable.getField(shareableAudienceType.getSourceTableKeyFieldName()).getType(), audienceIdString);
getInput.withUniqueKey(Map.of(shareableAudienceType.getSourceTableKeyFieldName(), audienceId));
}
else
{
audienceId = ValueUtils.getValueAsFieldType(audienceTable.getField(audienceTable.getPrimaryKeyField()).getType(), audienceIdString);
getInput.withPrimaryKey(audienceId);
}
QRecord audienceRecord = new GetAction().executeForRecord(getInput);
if(audienceRecord == null) if(audienceRecord == null)
{ {
throw (new QException("A record could not be found for audience type " + audienceType + ", audience id: " + audienceIdString)); throw (new QException("A record could not be found for audience type " + audienceType + ", audience id: " + audienceIdString));
@ -166,11 +184,15 @@ public class InsertSharedRecordProcess implements BackendStep, MetaDataProducerI
if(CollectionUtils.nullSafeHasContents(insertOutput.getRecords().get(0).getErrors())) if(CollectionUtils.nullSafeHasContents(insertOutput.getRecords().get(0).getErrors()))
{ {
QErrorMessage errorMessage = insertOutput.getRecords().get(0).getErrors().get(0); QErrorMessage errorMessage = insertOutput.getRecords().get(0).getErrors().get(0);
if(errorMessage instanceof BadInputStatusMessage) if(errorMessage instanceof DuplicateKeyBadInputStatusMessage)
{
throw (new QUserFacingException("This " + assetTableLabel + " has already been shared with this " + audienceTableLabel));
}
else if(errorMessage instanceof BadInputStatusMessage)
{ {
throw (new QUserFacingException(errorMessage.getMessage())); throw (new QUserFacingException(errorMessage.getMessage()));
} }
throw (new QException("Error inserting shared record: " + errorMessage.getMessage())); throw (new QException("Error sharing " + assetTableLabel + ": " + errorMessage.getMessage()));
} }
} }
catch(QException qe) catch(QException qe)
@ -179,7 +201,7 @@ public class InsertSharedRecordProcess implements BackendStep, MetaDataProducerI
} }
catch(Exception e) catch(Exception e)
{ {
throw (new QException("Error inserting shared record", e)); throw (new QException("Error sharing " + assetTableLabel, e));
} }
} }