diff --git a/.circleci/config.yml b/.circleci/config.yml index 573814e9..87d7748d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -37,6 +37,8 @@ commands: name: Run Maven command: | mvn -s .circleci/mvn-settings.xml << parameters.maven_subcommand >> + - store_artifacts: + path: target/site/jacoco - run: name: Save test results command: | diff --git a/.gitignore b/.gitignore index d2cf8a34..1223e629 100644 --- a/.gitignore +++ b/.gitignore @@ -28,3 +28,4 @@ target/ # virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml hs_err_pid* +.DS_Store diff --git a/pom.xml b/pom.xml index 56e0d11c..9d3b76e4 100644 --- a/pom.xml +++ b/pom.xml @@ -53,7 +53,7 @@ com.kingsrook.qqq qqq-backend-core - 0.2.0-20220726.150942-14 + 0.2.0-20220726.214150-15 diff --git a/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java b/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java index 9ff23830..84341c17 100644 --- a/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java +++ b/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java @@ -25,7 +25,6 @@ package com.kingsrook.qqq.backend.module.filesystem.base.actions; import java.io.File; import java.io.IOException; import java.io.InputStream; -import java.util.ArrayList; import java.util.List; import java.util.Optional; import java.util.function.Function; @@ -186,8 +185,7 @@ public abstract class AbstractBaseFilesystemAction try { - QueryOutput rs = new QueryOutput(queryInput); - List records = new ArrayList<>(); + QueryOutput queryOutput = new QueryOutput(queryInput); QTableMetaData table = queryInput.getTable(); AbstractFilesystemTableBackendDetails tableDetails = getTableBackendDetails(AbstractFilesystemTableBackendDetails.class, table); @@ -206,7 +204,7 @@ public abstract class AbstractBaseFilesystemAction List recordsInFile = new CsvToQRecordAdapter().buildRecordsFromCsv(fileContents, table, null); addBackendDetailsToRecords(recordsInFile, file); - records.addAll(recordsInFile); + queryOutput.addRecords(recordsInFile); break; } case JSON: @@ -217,7 +215,7 @@ public abstract class AbstractBaseFilesystemAction List recordsInFile = new JsonToQRecordAdapter().buildRecordsFromJson(fileContents, table, null); addBackendDetailsToRecords(recordsInFile, file); - records.addAll(recordsInFile); + queryOutput.addRecords(recordsInFile); break; } default: @@ -227,8 +225,7 @@ public abstract class AbstractBaseFilesystemAction } } - rs.addRecords(records); - return rs; + return queryOutput; } catch(Exception e) { diff --git a/src/test/java/com/kingsrook/qqq/backend/module/filesystem/TestUtils.java b/src/test/java/com/kingsrook/qqq/backend/module/filesystem/TestUtils.java index 177266a1..fd7d0714 100644 --- a/src/test/java/com/kingsrook/qqq/backend/module/filesystem/TestUtils.java +++ b/src/test/java/com/kingsrook/qqq/backend/module/filesystem/TestUtils.java @@ -220,9 +220,9 @@ public class TestUtils /******************************************************************************* ** *******************************************************************************/ - public static QSession getMockSession() + public static QSession getMockSession() throws QInstanceValidationException { MockAuthenticationModule mockAuthenticationModule = new MockAuthenticationModule(); - return (mockAuthenticationModule.createSession(null, null)); + return (mockAuthenticationModule.createSession(defineInstance(), null)); } } diff --git a/src/test/java/com/kingsrook/qqq/backend/module/filesystem/local/model/metadata/FilesystemBackendMetaDataTest.java b/src/test/java/com/kingsrook/qqq/backend/module/filesystem/local/model/metadata/FilesystemBackendMetaDataTest.java index 7c6515f6..e293c89a 100644 --- a/src/test/java/com/kingsrook/qqq/backend/module/filesystem/local/model/metadata/FilesystemBackendMetaDataTest.java +++ b/src/test/java/com/kingsrook/qqq/backend/module/filesystem/local/model/metadata/FilesystemBackendMetaDataTest.java @@ -70,8 +70,7 @@ class FilesystemBackendMetaDataTest String json = qInstanceAdapter.qInstanceToJsonIncludingBackend(qInstance); QInstance deserialized = qInstanceAdapter.jsonToQInstanceIncludingBackends(json); - assertThat(deserialized).usingRecursiveComparison() - .ignoringFields("hasBeenValidated") // note, this field is @JsonIgnore - .isEqualTo(qInstance); + assertThat(deserialized.getBackends()).usingRecursiveComparison() + .isEqualTo(qInstance.getBackends()); } } \ No newline at end of file diff --git a/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/model/metadata/S3BackendMetaDataTest.java b/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/model/metadata/S3BackendMetaDataTest.java index 58b57634..001fc6cb 100644 --- a/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/model/metadata/S3BackendMetaDataTest.java +++ b/src/test/java/com/kingsrook/qqq/backend/module/filesystem/s3/model/metadata/S3BackendMetaDataTest.java @@ -70,8 +70,7 @@ class S3BackendMetaDataTest String json = qInstanceAdapter.qInstanceToJsonIncludingBackend(qInstance); QInstance deserialized = qInstanceAdapter.jsonToQInstanceIncludingBackends(json); - assertThat(deserialized).usingRecursiveComparison() - .ignoringFields("hasBeenValidated") // note, this field is @JsonIgnore - .isEqualTo(qInstance); + assertThat(deserialized.getBackends()).usingRecursiveComparison() + .isEqualTo(qInstance.getBackends()); } } \ No newline at end of file