From e0597827ef8b4d4c83c488651a155df0df673624 Mon Sep 17 00:00:00 2001 From: Tim Chamberlain Date: Wed, 9 Oct 2024 10:30:49 -0500 Subject: [PATCH] CE-1836: updates from code review --- .../AbstractTableSyncTransformStep.java | 26 +++---------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/tablesync/AbstractTableSyncTransformStep.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/tablesync/AbstractTableSyncTransformStep.java index 7168321a..9b0934a0 100644 --- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/tablesync/AbstractTableSyncTransformStep.java +++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/tablesync/AbstractTableSyncTransformStep.java @@ -201,26 +201,6 @@ public abstract class AbstractTableSyncTransformStep extends AbstractTransformSt - /******************************************************************************* - ** - *******************************************************************************/ - void setPerformInserts(boolean performInserts) - { - this.setPerformInserts(performInserts); - } - - - - /******************************************************************************* - ** - *******************************************************************************/ - void setPerformUpdates(boolean performUpdates) - { - this.setPerformUpdates(performUpdates); - } - - - /******************************************************************************* ** artificial method, here to make jacoco see that this class is indeed ** included in test coverage... @@ -256,11 +236,11 @@ public abstract class AbstractTableSyncTransformStep extends AbstractTransformSt //////////////////////////////////////////////////////////// if(runBackendStepInput.getValueString(SYNC_TABLE_PERFORM_INSERTS_KEY) != null) { - config.setPerformInserts(Boolean.parseBoolean(runBackendStepInput.getValueString(SYNC_TABLE_PERFORM_INSERTS_KEY))); + config = new SyncProcessConfig(config.sourceTable, config.sourceTableKeyField, config.destinationTable, config.destinationTableForeignKey, true, config.performUpdates); } if(runBackendStepInput.getValueString(SYNC_TABLE_PERFORM_UPDATES_KEY) != null) { - config.setPerformUpdates(Boolean.parseBoolean(runBackendStepInput.getValueString(SYNC_TABLE_PERFORM_UPDATES_KEY))); + config = new SyncProcessConfig(config.sourceTable, config.sourceTableKeyField, config.destinationTable, config.destinationTableForeignKey, config.performUpdates, true); } String sourceTableKeyField = config.sourceTableKeyField; String destinationTableForeignKeyField = config.destinationTableForeignKey; @@ -412,7 +392,7 @@ public abstract class AbstractTableSyncTransformStep extends AbstractTransformSt } } - if(Boolean.parseBoolean(runBackendStepInput.getValueString(SYNC_TABLE_PERFORM_INSERTS_KEY))) + if(Boolean.parseBoolean(runBackendStepInput.getValueString(LOG_TRANSFORM_RESULTS))) { logResults(runBackendStepInput, config); }