Remove usages of log4j's placeholders-based log formatting calls (some of which were accidental and wrong anyway)

This commit is contained in:
2024-04-09 18:51:43 -05:00
parent b55631a767
commit c32d9110ce
6 changed files with 10 additions and 9 deletions

View File

@ -526,7 +526,7 @@ public class PollingAutomationPerTableRunner implements Runnable
// note - this method - will re-query the objects, so we should have confidence that their data is fresh... // // note - this method - will re-query the objects, so we should have confidence that their data is fresh... //
////////////////////////////////////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////////////////////////////////////
List<QRecord> matchingQRecords = getRecordsMatchingActionFilter(table, records, action); List<QRecord> matchingQRecords = getRecordsMatchingActionFilter(table, records, action);
LOG.debug("Of the {} records that were pending automations, {} of them match the filter on the action {}", records.size(), matchingQRecords.size(), action); LOG.debug("Of the [" + records.size() + "] records that were pending automations, [" + matchingQRecords.size() + "] of them match the filter on the action:" + action);
if(CollectionUtils.nullSafeHasContents(matchingQRecords)) if(CollectionUtils.nullSafeHasContents(matchingQRecords))
{ {
LOG.debug(" Processing " + matchingQRecords.size() + " records in " + table + " for action " + action); LOG.debug(" Processing " + matchingQRecords.size() + " records in " + table + " for action " + action);
@ -601,7 +601,7 @@ public class PollingAutomationPerTableRunner implements Runnable
/******************************************************************************* /*******************************************************************************
** Finally, actually run action code against a list of known matching records. ** Finally, actually run action code against a list of known matching records.
** todo not commit - move to somewhere genericer **
*******************************************************************************/ *******************************************************************************/
public static void applyActionToMatchingRecords(QTableMetaData table, List<QRecord> records, TableAutomationAction action) throws Exception public static void applyActionToMatchingRecords(QTableMetaData table, List<QRecord> records, TableAutomationAction action) throws Exception
{ {

View File

@ -96,7 +96,7 @@ public class QCodeLoader
} }
catch(Exception e) catch(Exception e)
{ {
LOG.error("Error initializing customizer", logPair("codeReference", codeReference), e); LOG.error("Error initializing customizer", e, logPair("codeReference", codeReference));
////////////////////////////////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////////////////////////////////
// return null here - under the assumption that during normal run-time operations, we'll never hit here // // return null here - under the assumption that during normal run-time operations, we'll never hit here //
@ -135,7 +135,7 @@ public class QCodeLoader
} }
catch(Exception e) catch(Exception e)
{ {
LOG.error("Error initializing customizer", logPair("codeReference", codeReference), e); LOG.error("Error initializing customizer", e, logPair("codeReference", codeReference));
////////////////////////////////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////////////////////////////////
// return null here - under the assumption that during normal run-time operations, we'll never hit here // // return null here - under the assumption that during normal run-time operations, we'll never hit here //
@ -187,7 +187,7 @@ public class QCodeLoader
} }
catch(Exception e) catch(Exception e)
{ {
LOG.error("Error initializing customizer", logPair("codeReference", codeReference), e); LOG.error("Error initializing customizer", e, logPair("codeReference", codeReference));
////////////////////////////////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////////////////////////////////
// return null here - under the assumption that during normal run-time operations, we'll never hit here // // return null here - under the assumption that during normal run-time operations, we'll never hit here //

View File

@ -138,7 +138,7 @@ public class RecordPipe
{ {
if(now - sleepLoopStartTime > MAX_SLEEP_LOOP_MILLIS) if(now - sleepLoopStartTime > MAX_SLEEP_LOOP_MILLIS)
{ {
LOG.warn("Giving up adding record to pipe, due to pipe being full for more than {} millis", MAX_SLEEP_LOOP_MILLIS); LOG.warn("Giving up adding record to pipe, due to pipe being full for more than " + MAX_SLEEP_LOOP_MILLIS + " millis");
throw (new IllegalStateException("Giving up adding record to pipe, due to pipe staying full too long.")); throw (new IllegalStateException("Giving up adding record to pipe, due to pipe staying full too long."));
} }
LOG.trace("Record pipe.add failed (due to full pipe). Blocking."); LOG.trace("Record pipe.add failed (due to full pipe). Blocking.");

View File

@ -150,7 +150,7 @@ public class MetaDataProducerHelper
} }
catch(Exception e) catch(Exception e)
{ {
LOG.warn("error executing metaDataProducer", logPair("producer", producer.getClass().getSimpleName()), e); LOG.warn("error executing metaDataProducer", e, logPair("producer", producer.getClass().getSimpleName()));
} }
} }
else else

View File

@ -27,6 +27,7 @@ import java.util.Map;
import com.kingsrook.qqq.backend.core.exceptions.QModuleDispatchException; import com.kingsrook.qqq.backend.core.exceptions.QModuleDispatchException;
import com.kingsrook.qqq.backend.core.logging.QLogger; import com.kingsrook.qqq.backend.core.logging.QLogger;
import com.kingsrook.qqq.backend.core.model.metadata.QBackendMetaData; import com.kingsrook.qqq.backend.core.model.metadata.QBackendMetaData;
import static com.kingsrook.qqq.backend.core.logging.LogUtils.logPair;
/******************************************************************************* /*******************************************************************************
@ -89,7 +90,7 @@ public class QBackendModuleDispatcher
} }
catch(Exception e) catch(Exception e)
{ {
LOG.debug("Backend module [{}] could not be loaded: {}", moduleClassName, e.getMessage()); LOG.debug("Backend module could not be loaded", e, logPair("moduleClassName", moduleClassName));
} }
} }

View File

@ -56,7 +56,7 @@ public class MockBackendStep implements BackendStep
runBackendStepInput.getRecords().forEach(r -> runBackendStepInput.getRecords().forEach(r ->
{ {
LOG.info("We are mocking {}: {}", r.getValueString("firstName"), r.getValue(FIELD_MOCK_VALUE)); LOG.info("We are mocking " + r.getValueString("firstName") + ": " + r.getValue(FIELD_MOCK_VALUE));
r.setValue(FIELD_MOCK_VALUE, "Ha ha!"); r.setValue(FIELD_MOCK_VALUE, "Ha ha!");
r.setValue("greetingMessage", runBackendStepInput.getValueString(FIELD_GREETING_PREFIX) + " " + r.getValueString("firstName") + " " + runBackendStepInput.getValueString(FIELD_GREETING_SUFFIX)); r.setValue("greetingMessage", runBackendStepInput.getValueString(FIELD_GREETING_PREFIX) + " " + r.getValueString("firstName") + " " + runBackendStepInput.getValueString(FIELD_GREETING_SUFFIX));
}); });