From bc3f462d1339eb39c56f5fd74d2cec6642180b33 Mon Sep 17 00:00:00 2001
From: Darin Kelkhoff <darin.kelkhoff@gmail.com>
Date: Mon, 8 Jan 2024 12:31:37 -0600
Subject: [PATCH] CE-781 log (once) & noop for tables w/o integer primary key,
 as that is required for auditing...

---
 .../core/actions/audits/DMLAuditAction.java     | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
index 2f82cb45..e304e28a 100644
--- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
+++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
@@ -30,10 +30,12 @@ import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
+import java.util.Set;
 import com.kingsrook.qqq.backend.core.actions.AbstractQActionFunction;
 import com.kingsrook.qqq.backend.core.actions.values.QPossibleValueTranslator;
 import com.kingsrook.qqq.backend.core.actions.values.QValueFormatter;
@@ -73,6 +75,7 @@ public class DMLAuditAction extends AbstractQActionFunction<DMLAuditInput, DMLAu
 
    public static final String AUDIT_CONTEXT_FIELD_NAME = "auditContext";
 
+   private static Set<String> loggedUnauditableTableNames = new HashSet<>();
 
 
    /*******************************************************************************
@@ -88,6 +91,20 @@ public class DMLAuditAction extends AbstractQActionFunction<DMLAuditInput, DMLAu
       long                     start            = System.currentTimeMillis();
       DMLType                  dmlType          = getDMLType(tableActionInput);
 
+      //////////////////////////////////////////////////////////////////////////////////////////////////
+      // currently, the table's primary key must be id... so, log (once) and return early if not that //
+      //////////////////////////////////////////////////////////////////////////////////////////////////
+      QFieldMetaData field = table.getField(table.getPrimaryKeyField());
+      if(!QFieldType.INTEGER.equals(field.getType()))
+      {
+         if(!loggedUnauditableTableNames.contains(table.getName()))
+         {
+            LOG.info("Cannot audit table without integer as its primary key", logPair("tableName", table.getName()));
+            loggedUnauditableTableNames.add(table.getName());
+         }
+         return (output);
+      }
+
       try
       {
          List<QRecord> recordList = CollectionUtils.nonNullList(input.getRecordList()).stream()