QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-18 13:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed to do index++ when fetching generated ids (with test coverage)

Browse Source
This commit is contained in:
Darin Kelkhoff
2021-12-01 22:58:08 -06:00
parent 3956a28e70
commit b6a664ac89
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSInsertAction.java
View File

@ -80,7 +80,7 @@ public class RDBMSInsertAction extends AbstractRDBMSAction implements InsertInte
int index = 0; int index = 0;
for(QRecord record : insertRequest.getRecords()) for(QRecord record : insertRequest.getRecords())
{ {
Integer id = idList.get(index); Integer id = idList.get(index++);
QRecordWithStatus recordWithStatus = new QRecordWithStatus(record); QRecordWithStatus recordWithStatus = new QRecordWithStatus(record);
recordWithStatus.setPrimaryKey(id); recordWithStatus.setPrimaryKey(id);
recordWithStatus.setValue(table.getPrimaryKeyField(), id); recordWithStatus.setValue(table.getPrimaryKeyField(), id);

4
src/test/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSInsertActionTest.java
View File

@ -81,8 +81,8 @@ public class RDBMSInsertActionTest extends RDBMSActionTest
insertRequest.setRecords(List.of(record1, record2)); insertRequest.setRecords(List.of(record1, record2));
InsertResult insertResult = new RDBMSInsertAction().execute(insertRequest); InsertResult insertResult = new RDBMSInsertAction().execute(insertRequest);
assertEquals(2, insertResult.getRecords().size(), "Should return 1 row"); assertEquals(2, insertResult.getRecords().size(), "Should return 1 row");
assertNotNull(insertResult.getRecords().get(0).getValue("id"), "Should have an id in the row"); assertEquals(6, insertResult.getRecords().get(0).getValue("id"), "Should have next id in the row");
assertNotNull(insertResult.getRecords().get(1).getValue("id"), "Should have an id in the row"); assertEquals(7, insertResult.getRecords().get(1).getValue("id"), "Should have next id in the row");
assertTrue(insertResult.getRecords().stream().noneMatch(qrs -> CollectionUtils.nullSafeHasContents(qrs.getErrors())), "There should be no errors"); assertTrue(insertResult.getRecords().stream().noneMatch(qrs -> CollectionUtils.nullSafeHasContents(qrs.getErrors())), "There should be no errors");
runTestSql("SELECT * FROM person WHERE last_name = 'Picard'", (rs -> { runTestSql("SELECT * FROM person WHERE last_name = 'Picard'", (rs -> {
int rowsFound = 0; int rowsFound = 0;