From b1c287a4e296e620a317f1e7775c2015fe5191da Mon Sep 17 00:00:00 2001 From: Darin Kelkhoff Date: Mon, 16 Oct 2023 08:59:36 -0500 Subject: [PATCH] Moved getValueAsString call from last commit into earlier check for "%s" --- .../core/actions/values/QValueFormatter.java | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/values/QValueFormatter.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/values/QValueFormatter.java index 0a0f0161..7dc51ca4 100644 --- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/values/QValueFormatter.java +++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/values/QValueFormatter.java @@ -112,6 +112,12 @@ public class QValueFormatter { return formatLocalTime(lt); } + + ////////////////////////////////////////////////////////////////////////////////////////// + // else, just return the value as a string, rather than going through String.formatted // + // this saves some overhead incurred by String.formatted when called millions of times. // + ////////////////////////////////////////////////////////////////////////////////////////// + return (ValueUtils.getValueAsString(value)); } //////////////////////////////////////////////////////// @@ -119,15 +125,6 @@ public class QValueFormatter //////////////////////////////////////////////////////// if(StringUtils.hasContent(displayFormat)) { - ////////////////////////////////////////////////////////////////////////////////////////// - // if the format is %s (the default), just return value a string // - // this saves some overhead incurred by String.formatted when called millions of times. // - ////////////////////////////////////////////////////////////////////////////////////////// - if(displayFormat.equals("%s")) - { - return (ValueUtils.getValueAsString(value)); - } - try { return (displayFormat.formatted(value));