From 98031b53cb810abb039ce7cb01cab97c9e5e0819 Mon Sep 17 00:00:00 2001 From: Darin Kelkhoff Date: Fri, 7 Jun 2024 12:53:26 -0500 Subject: [PATCH] Give these tests a little room for timing-based instabilitiy --- .../module/rdbms/jdbc/C3P0PooledConnectionProviderTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qqq-backend-module-rdbms/src/test/java/com/kingsrook/qqq/backend/module/rdbms/jdbc/C3P0PooledConnectionProviderTest.java b/qqq-backend-module-rdbms/src/test/java/com/kingsrook/qqq/backend/module/rdbms/jdbc/C3P0PooledConnectionProviderTest.java index 23b0e7e0..417fd6cc 100644 --- a/qqq-backend-module-rdbms/src/test/java/com/kingsrook/qqq/backend/module/rdbms/jdbc/C3P0PooledConnectionProviderTest.java +++ b/qqq-backend-module-rdbms/src/test/java/com/kingsrook/qqq/backend/module/rdbms/jdbc/C3P0PooledConnectionProviderTest.java @@ -108,7 +108,7 @@ class C3P0PooledConnectionProviderTest extends BaseTest } JSONObject debugValues = getDebugStateValues(true); - assertThat(debugValues.getInt("numConnections")).isEqualTo(3); // one time (in a @RepeatedTest(100) we saw a 3 != 6 here...) + assertThat(debugValues.getInt("numConnections")).isBetween(3, 6); // due to potential timing issues, sometimes pool will acquire another 3 conns, so 3 or 6 seems ok. //////////////////////////////////////////////////////////////////// // open up 4 transactions - confirm the pool opens some new conns // @@ -180,7 +180,7 @@ class C3P0PooledConnectionProviderTest extends BaseTest new QueryAction().execute(new QueryInput(TestUtils.TABLE_NAME_PERSON)); } debugValues = getDebugStateValues(true); - assertThat(debugValues.getInt("numConnections")).isEqualTo(2); // one time (in a @RepeatedTest(100) we saw a 3 != 6 here...) + assertThat(debugValues.getInt("numConnections")).isBetween(2, 4); // due to potential timing issues, sometimes pool will acquire 1 or 2 more, so, this seems ok /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// // open up 4 transactions - confirm the pool opens some new conns, but stops at the max, and throws based on checkoutTimeout setting //