From 939dcc308c93b8c788695dbe578bb071f1501d36 Mon Sep 17 00:00:00 2001 From: Darin Kelkhoff Date: Thu, 16 Mar 2023 09:06:09 -0500 Subject: [PATCH] Fix test; add comment --- .../implementations/columnstats/ColumnStatsStep.java | 4 +++- .../backend/core/instances/QInstanceValidatorTest.java | 10 +++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/columnstats/ColumnStatsStep.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/columnstats/ColumnStatsStep.java index ae6dc962..40777447 100644 --- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/columnstats/ColumnStatsStep.java +++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/columnstats/ColumnStatsStep.java @@ -59,7 +59,9 @@ import com.kingsrook.qqq.backend.core.utils.ValueUtils; /******************************************************************************* - ** + ** This is a single-step process used to provide Column Statistics. These include + ** counts per-value for a field, plus things like total count, min, max, avg, based + ** on the field type. *******************************************************************************/ public class ColumnStatsStep implements BackendStep { diff --git a/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/instances/QInstanceValidatorTest.java b/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/instances/QInstanceValidatorTest.java index 61f803bf..0bedf9ae 100644 --- a/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/instances/QInstanceValidatorTest.java +++ b/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/instances/QInstanceValidatorTest.java @@ -347,11 +347,11 @@ class QInstanceValidatorTest extends BaseTest @Test public void test_validateProcessStepWithEmptyName() { - /////////////////////////////////////////////////////////////////////////////////////////////////////////////////// - // these used to be an assertion failure - but enricher now sets a default name for backend steps w/ a code name // - /////////////////////////////////////////////////////////////////////////////////////////////////////////////////// - assertValidationSuccess((qInstance) -> qInstance.getProcess(TestUtils.PROCESS_NAME_GREET_PEOPLE).getStepList().get(0).setName("")); - assertValidationSuccess((qInstance) -> qInstance.getProcess(TestUtils.PROCESS_NAME_GREET_PEOPLE_INTERACTIVE).getStepList().get(1).setName(null)); + assertValidationFailureReasons((qInstance) -> qInstance.getProcess(TestUtils.PROCESS_NAME_GREET_PEOPLE).getStepList().get(0).setName(""), + "Missing name for a step"); + + assertValidationFailureReasons((qInstance) -> qInstance.getProcess(TestUtils.PROCESS_NAME_GREET_PEOPLE_INTERACTIVE).getStepList().get(1).setName(null), + "Missing name for a step"); }