QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-18 05:01:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

CE-781 Feedback from code review

Browse Source
This commit is contained in:
darin.kelkhoff
2024-01-17 19:09:19 -06:00
parent a845ead466
commit 911978c74b
5 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
View File

@ -91,9 +91,9 @@ public class DMLAuditAction extends AbstractQActionFunction<DMLAuditInput, DMLAu
long start = System.currentTimeMillis(); long start = System.currentTimeMillis();
DMLType dmlType = getDMLType(tableActionInput); DMLType dmlType = getDMLType(tableActionInput);
////////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////////////
// currently, the table's primary key must be id... so, log (once) and return early if not that // // currently, the table's primary key must be integer... so, log (once) and return early if not that //
////////////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////////////////
QFieldMetaData field = table.getField(table.getPrimaryKeyField()); QFieldMetaData field = table.getField(table.getPrimaryKeyField());
if(!QFieldType.INTEGER.equals(field.getType())) if(!QFieldType.INTEGER.equals(field.getType()))
{ {

3
qqq-backend-module-mongodb/src/main/java/com/kingsrook/qqq/backend/module/mongodb/actions/MongoDBAggregateAction.java
View File

@ -45,7 +45,6 @@ import com.kingsrook.qqq.backend.core.model.metadata.fields.QFieldType;
import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData; import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData;
import com.kingsrook.qqq.backend.core.utils.CollectionUtils; import com.kingsrook.qqq.backend.core.utils.CollectionUtils;
import com.kingsrook.qqq.backend.core.utils.ValueUtils; import com.kingsrook.qqq.backend.core.utils.ValueUtils;
import com.kingsrook.qqq.backend.module.mongodb.MongoDBBackendModule;
import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData; import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData;
import com.mongodb.client.AggregateIterable; import com.mongodb.client.AggregateIterable;
import com.mongodb.client.MongoCollection; import com.mongodb.client.MongoCollection;
@ -62,7 +61,7 @@ import org.bson.conversions.Bson;
*******************************************************************************/ *******************************************************************************/
public class MongoDBAggregateAction extends AbstractMongoDBAction implements AggregateInterface public class MongoDBAggregateAction extends AbstractMongoDBAction implements AggregateInterface
{ {
private static final QLogger LOG = QLogger.getLogger(MongoDBBackendModule.class); private static final QLogger LOG = QLogger.getLogger(MongoDBAggregateAction.class);
private ActionTimeoutHelper actionTimeoutHelper; private ActionTimeoutHelper actionTimeoutHelper;

3
qqq-backend-module-mongodb/src/main/java/com/kingsrook/qqq/backend/module/mongodb/actions/MongoDBCountAction.java
View File

@ -34,7 +34,6 @@ import com.kingsrook.qqq.backend.core.model.actions.tables.count.CountInput;
import com.kingsrook.qqq.backend.core.model.actions.tables.count.CountOutput; import com.kingsrook.qqq.backend.core.model.actions.tables.count.CountOutput;
import com.kingsrook.qqq.backend.core.model.actions.tables.query.QQueryFilter; import com.kingsrook.qqq.backend.core.model.actions.tables.query.QQueryFilter;
import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData; import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData;
import com.kingsrook.qqq.backend.module.mongodb.MongoDBBackendModule;
import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData; import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData;
import com.mongodb.client.AggregateIterable; import com.mongodb.client.AggregateIterable;
import com.mongodb.client.MongoCollection; import com.mongodb.client.MongoCollection;
@ -50,7 +49,7 @@ import org.bson.conversions.Bson;
*******************************************************************************/ *******************************************************************************/
public class MongoDBCountAction extends AbstractMongoDBAction implements CountInterface public class MongoDBCountAction extends AbstractMongoDBAction implements CountInterface
{ {
private static final QLogger LOG = QLogger.getLogger(MongoDBBackendModule.class); private static final QLogger LOG = QLogger.getLogger(MongoDBCountAction.class);
private ActionTimeoutHelper actionTimeoutHelper; private ActionTimeoutHelper actionTimeoutHelper;

3
qqq-backend-module-mongodb/src/main/java/com/kingsrook/qqq/backend/module/mongodb/actions/MongoDBDeleteAction.java
View File

@ -33,7 +33,6 @@ import com.kingsrook.qqq.backend.core.model.actions.tables.query.QQueryFilter;
import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData; import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData;
import com.kingsrook.qqq.backend.core.utils.CollectionUtils; import com.kingsrook.qqq.backend.core.utils.CollectionUtils;
import com.kingsrook.qqq.backend.core.utils.ValueUtils; import com.kingsrook.qqq.backend.core.utils.ValueUtils;
import com.kingsrook.qqq.backend.module.mongodb.MongoDBBackendModule;
import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData; import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData;
import com.mongodb.client.MongoCollection; import com.mongodb.client.MongoCollection;
import com.mongodb.client.MongoDatabase; import com.mongodb.client.MongoDatabase;
@ -50,7 +49,7 @@ import static com.kingsrook.qqq.backend.core.logging.LogUtils.logPair;
*******************************************************************************/ *******************************************************************************/
public class MongoDBDeleteAction extends AbstractMongoDBAction implements DeleteInterface public class MongoDBDeleteAction extends AbstractMongoDBAction implements DeleteInterface
{ {
private static final QLogger LOG = QLogger.getLogger(MongoDBBackendModule.class); private static final QLogger LOG = QLogger.getLogger(MongoDBDeleteAction.class);

3
qqq-backend-module-mongodb/src/main/java/com/kingsrook/qqq/backend/module/mongodb/actions/MongoDBQueryAction.java
View File

@ -37,7 +37,6 @@ import com.kingsrook.qqq.backend.core.model.actions.tables.query.QueryOutput;
import com.kingsrook.qqq.backend.core.model.data.QRecord; import com.kingsrook.qqq.backend.core.model.data.QRecord;
import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData; import com.kingsrook.qqq.backend.core.model.metadata.tables.QTableMetaData;
import com.kingsrook.qqq.backend.core.utils.CollectionUtils; import com.kingsrook.qqq.backend.core.utils.CollectionUtils;
import com.kingsrook.qqq.backend.module.mongodb.MongoDBBackendModule;
import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData; import com.kingsrook.qqq.backend.module.mongodb.model.metadata.MongoDBBackendMetaData;
import com.mongodb.client.FindIterable; import com.mongodb.client.FindIterable;
import com.mongodb.client.MongoCollection; import com.mongodb.client.MongoCollection;
@ -51,7 +50,7 @@ import org.bson.conversions.Bson;
*******************************************************************************/ *******************************************************************************/
public class MongoDBQueryAction extends AbstractMongoDBAction implements QueryInterface public class MongoDBQueryAction extends AbstractMongoDBAction implements QueryInterface
{ {
private static final QLogger LOG = QLogger.getLogger(MongoDBBackendModule.class); private static final QLogger LOG = QLogger.getLogger(MongoDBQueryAction.class);
private ActionTimeoutHelper actionTimeoutHelper; private ActionTimeoutHelper actionTimeoutHelper;