QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-19 21:50:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change to fetch the variant record - helps w/ input values being in other types, and, verifies the record exists!

Browse Source
This commit is contained in:
darin.kelkhoff
2025-05-23 12:02:56 -05:00
parent 63b956a032
commit 802d367b94
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/modules/backend/implementations/memory/MemoryRecordStore.java
View File

@ -176,7 +176,8 @@ public class MemoryRecordStore
if(backendVariantsConfig != null) if(backendVariantsConfig != null)
{ {
String variantType = backendMetaData.getBackendVariantsConfig().getVariantTypeKey(); String variantType = backendMetaData.getBackendVariantsConfig().getVariantTypeKey();
Serializable variantId = BackendVariantsUtil.getVariantId(backendMetaData); QRecord variantRecord = BackendVariantsUtil.getVariantRecord(backendMetaData);
Serializable variantId = variantRecord.getValue(QContext.getQInstance().getTable(variantRecord.getTableName()).getPrimaryKeyField());
backendIdentifier = new Variant(variantType, variantId); backendIdentifier = new Variant(variantType, variantId);
} }
return backendIdentifier; return backendIdentifier;

17
qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/modules/backend/implementations/memory/MemoryBackendModuleTest.java
View File

@ -247,15 +247,24 @@ class MemoryBackendModuleTest extends BaseTest
))).getRecords().get(0).getValueInteger("id"); ))).getRecords().get(0).getValueInteger("id");
assertEquals(1, planetId1); assertEquals(1, planetId1);
//////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////////////////
// make sure counts return what we expect per-variant // // make sure counts return what we expect per-variant //
//////////////////////////////////////////////////////// // also, put the variant ids as strings, just to make sure we're a little type-flexible there //
QContext.getQSession().setBackendVariants(Map.of(TestUtils.TABLE_NAME_MEMORY_VARIANT_OPTIONS, 2)); ////////////////////////////////////////////////////////////////////////////////////////////////
QContext.getQSession().setBackendVariants(Map.of(TestUtils.TABLE_NAME_MEMORY_VARIANT_OPTIONS, "2"));
assertEquals(3, new CountAction().execute(new CountInput(TestUtils.TABLE_NAME_MEMORY_VARIANT_DATA)).getCount()); assertEquals(3, new CountAction().execute(new CountInput(TestUtils.TABLE_NAME_MEMORY_VARIANT_DATA)).getCount());
QContext.getQSession().setBackendVariants(Map.of(TestUtils.TABLE_NAME_MEMORY_VARIANT_OPTIONS, 1)); QContext.getQSession().setBackendVariants(Map.of(TestUtils.TABLE_NAME_MEMORY_VARIANT_OPTIONS, "1"));
assertEquals(1, new CountAction().execute(new CountInput(TestUtils.TABLE_NAME_MEMORY_VARIANT_DATA)).getCount()); assertEquals(1, new CountAction().execute(new CountInput(TestUtils.TABLE_NAME_MEMORY_VARIANT_DATA)).getCount());
/////////////////////////////////////////////
// assert we fail if trying unknown variant //
/////////////////////////////////////////////
QContext.getQSession().setBackendVariants(Map.of(TestUtils.TABLE_NAME_MEMORY_VARIANT_OPTIONS, 4));
assertThatThrownBy(() -> new InsertAction().execute(new InsertInput(TestUtils.TABLE_NAME_MEMORY_VARIANT_DATA).withRecords(List.of(
new QRecord().withValue("id", 1).withValue("name", "England")
)))).hasMessageContaining("Could not find Backend Variant in table memoryVariantOptions with id '4'");
} }