From 71ecde74df7fe897637ae6cd20f9cef9eea98a64 Mon Sep 17 00:00:00 2001
From: Darin Kelkhoff <darin.kelkhoff@gmail.com>
Date: Tue, 12 Mar 2024 14:28:46 -0500
Subject: [PATCH] jdbc Connections in try-with-resources (so they close and
 return to connection pool)

---
 .../qqq/frontend/picocli/TestUtils.java       | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/qqq-middleware-picocli/src/test/java/com/kingsrook/qqq/frontend/picocli/TestUtils.java b/qqq-middleware-picocli/src/test/java/com/kingsrook/qqq/frontend/picocli/TestUtils.java
index 847dc9d8..cb226925 100644
--- a/qqq-middleware-picocli/src/test/java/com/kingsrook/qqq/frontend/picocli/TestUtils.java
+++ b/qqq-middleware-picocli/src/test/java/com/kingsrook/qqq/frontend/picocli/TestUtils.java
@@ -60,16 +60,18 @@ public class TestUtils
    @SuppressWarnings("unchecked")
    public static void primeTestDatabase() throws Exception
    {
-      ConnectionManager connectionManager          = new ConnectionManager();
-      Connection        connection                 = connectionManager.getConnection(TestUtils.defineBackend());
-      InputStream       primeTestDatabaseSqlStream = TestUtils.class.getResourceAsStream("/prime-test-database.sql");
-      assertNotNull(primeTestDatabaseSqlStream);
-      List<String> lines = (List<String>) IOUtils.readLines(primeTestDatabaseSqlStream);
-      lines = lines.stream().filter(line -> !line.startsWith("-- ")).toList();
-      String joinedSQL = String.join("\n", lines);
-      for(String sql : joinedSQL.split(";"))
+      ConnectionManager connectionManager = new ConnectionManager();
+      try(Connection connection = connectionManager.getConnection(TestUtils.defineBackend()))
       {
-         QueryManager.executeUpdate(connection, sql);
+         InputStream primeTestDatabaseSqlStream = TestUtils.class.getResourceAsStream("/prime-test-database.sql");
+         assertNotNull(primeTestDatabaseSqlStream);
+         List<String> lines = (List<String>) IOUtils.readLines(primeTestDatabaseSqlStream);
+         lines = lines.stream().filter(line -> !line.startsWith("-- ")).toList();
+         String joinedSQL = String.join("\n", lines);
+         for(String sql : joinedSQL.split(";"))
+         {
+            QueryManager.executeUpdate(connection, sql);
+         }
       }
    }
 
@@ -82,8 +84,10 @@ public class TestUtils
    public static void runTestSql(String sql, QueryManager.ResultSetProcessor resultSetProcessor) throws Exception
    {
       ConnectionManager connectionManager = new ConnectionManager();
-      Connection        connection        = connectionManager.getConnection(defineBackend());
-      QueryManager.executeStatement(connection, sql, resultSetProcessor);
+      try(Connection connection = connectionManager.getConnection(defineBackend()))
+      {
+         QueryManager.executeStatement(connection, sql, resultSetProcessor);
+      }
    }