Upgrade checkstyle; remove supressed indentation markers for new-style switches

pom.xml

@@ -150,7 +150,7 @@
                <dependency>
                   <groupId>com.puppycrawl.tools</groupId>
                   <artifactId>checkstyle</artifactId>
-                  <version>9.0</version>
+                  <version>10.16.0</version>
                </dependency>
             </dependencies>
             <executions>

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/automation/AutomationStatus.java

@@ -127,7 +127,6 @@ public enum AutomationStatus implements PossibleValueEnum<Integer>
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public String getInsertOrUpdate()
    {
       return switch(this)

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/customizers/RecordCustomizerUtilityInterface.java

@@ -50,10 +50,7 @@ public interface RecordCustomizerUtilityInterface
    /*******************************************************************************
     ** Container for an old value and a new value.
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:MethodName")
+   record Change(Serializable oldValue, Serializable newValue) {}
-   record Change(Serializable oldValue, Serializable newValue)
-   {
-   }
 
 
    /*******************************************************************************

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/dashboard/widgets/DateTimeGroupBy.java

@@ -256,7 +256,6 @@ public enum DateTimeGroupBy
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public Instant roundDown(Instant instant, ZoneId zoneId)
    {
       ZonedDateTime zoned = instant.atZone(zoneId);

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/permissions/PermissionsHelper.java

@@ -500,7 +500,6 @@ public class PermissionsHelper
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    static PermissionSubType getEffectivePermissionSubType(QPermissionRules rules, PermissionSubType originalPermissionSubType)
    {
       if(rules == null || rules.getLevel() == null)

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/scripts/ExecuteCodeAction.java

@@ -77,7 +77,6 @@ public class ExecuteCodeAction
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public void run(ExecuteCodeInput input, ExecuteCodeOutput output) throws QException, QCodeException
    {
       QCodeReference codeReference = input.getCodeReference();

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/tables/helpers/ValidateRecordSecurityLockHelper.java

@@ -390,7 +390,6 @@ public class ValidateRecordSecurityLockHelper
     ** MultiRecordSecurityLock, with only the appropriate lock-scopes being included
     ** (e.g., read-locks for selects, write-locks for insert/update/delete).
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    static MultiRecordSecurityLock getRecordSecurityLocks(QTableMetaData table, Action action)
    {
       List<RecordSecurityLock> allLocksOnTable = CollectionUtils.nonNullList(table.getRecordSecurityLocks());

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/values/QPossibleValueTranslator.java

@@ -118,6 +118,7 @@ public class QPossibleValueTranslator
    }
 
 
+
    /*******************************************************************************
     ** Constructor
     **
@@ -421,7 +422,6 @@ public class QPossibleValueTranslator
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    private String doFormatPossibleValue(String formatString, List<String> valueFields, Object id, String label)
    {
       List<Object> values = new ArrayList<>();

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/fields/DisplayFormat.java

@@ -49,7 +49,6 @@ public interface DisplayFormat
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    static String getExcelFormat(String javaDisplayFormat)
    {
       if(javaDisplayFormat == null)

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/joins/JoinType.java

@@ -44,7 +44,6 @@ public enum JoinType
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public JoinType flip()
    {
       return switch(this)

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/serialization/QStepMetaDataDeserializer.java

@@ -39,8 +39,11 @@ import com.kingsrook.qqq.backend.core.model.metadata.processes.QStepMetaData;
  *******************************************************************************/
 public class QStepMetaDataDeserializer extends JsonDeserializer<QStepMetaData>
 {
+
+   /***************************************************************************
+    **
+    ***************************************************************************/
    @Override
-   @SuppressWarnings("checkstyle:Indentation")
    public QStepMetaData deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException, JacksonException
    {
       TreeNode treeNode = jsonParser.readValueAsTree();

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/modules/backend/implementations/memory/MemoryRecordStore.java

@@ -769,7 +769,6 @@ public class MemoryRecordStore
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    private static Serializable computeAggregate(List<QRecord> records, Aggregate aggregate, QTableMetaData table)
    {
       String            fieldName = aggregate.getFieldName();

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/modules/backend/implementations/mock/MockCountAction.java

@@ -38,7 +38,6 @@ public class MockCountAction implements CountInterface
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:MagicNumber")
    public CountOutput execute(CountInput countInput) throws QException
    {
       try

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/modules/backend/implementations/mock/MockQueryAction.java

@@ -95,10 +95,8 @@ public class MockQueryAction implements QueryInterface
     ** Get a mock value to use, based on its type.
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:MagicNumber")
    public static Serializable getMockValue(QTableMetaData table, String field)
    {
-      // @formatter:off // IJ can't do new-style switch correctly yet...
       return switch(table.getField(field).getType())
       {
          case STRING -> UUID.randomUUID().toString();
@@ -112,7 +110,6 @@ public class MockQueryAction implements QueryInterface
          case PASSWORD -> "abc***234";
          default -> throw new IllegalStateException("Unexpected value: " + table.getField(field).getType());
       };
-      // @formatter:on
    }
 
 }

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/modules/backend/implementations/utils/BackendQueryFilterUtils.java

@@ -134,7 +134,6 @@ public class BackendQueryFilterUtils
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public static boolean doesCriteriaMatch(QFilterCriteria criterion, String fieldName, Serializable value)
    {
       ListIterator<Serializable> valueListIterator = criterion.getValues().listIterator();

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/etl/streamedwithfrontend/StreamedETLExecuteStep.java

@@ -58,7 +58,6 @@ public class StreamedETLExecuteStep extends BaseStreamedETLStep implements Backe
     **
     *******************************************************************************/
    @Override
-   @SuppressWarnings("checkstyle:indentation")
    public void run(RunBackendStepInput runBackendStepInput, RunBackendStepOutput runBackendStepOutput) throws QException
    {
       Optional<QBackendTransaction> transaction = Optional.empty();

qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/utils/ValueUtils.java

@@ -793,7 +793,6 @@ public class ValueUtils
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public static Serializable getValueAsFieldType(QFieldType type, Object value)
    {
       return switch(type)

qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/actions/AbstractBaseFilesystemAction.java

@@ -195,7 +195,6 @@ public abstract class AbstractBaseFilesystemAction<FILE>
    /*******************************************************************************
     ** Generic implementation of the execute method from the QueryInterface
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    public QueryOutput executeQuery(QueryInput queryInput) throws QException
    {
       preAction(queryInput.getBackend());

qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/base/model/metadata/FilesystemTableMetaDataBuilder.java

@@ -58,7 +58,6 @@ public class FilesystemTableMetaDataBuilder
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    public QTableMetaData buildStandardCardinalityOneTable()
    {
       AbstractFilesystemTableBackendDetails tableBackendDetails = switch(backend.getBackendType())

qqq-backend-module-filesystem/src/main/java/com/kingsrook/qqq/backend/module/filesystem/processes/implementations/filesystem/importer/FilesystemImporterStep.java

@@ -101,6 +101,7 @@ public class FilesystemImporterStep implements BackendStep
    private Function<QRecord, Serializable> securitySupplier = null;
 
 
+
    /*******************************************************************************
     ** Execute the step - using the request as input, and the result as output.
     *******************************************************************************/
@@ -373,7 +374,6 @@ public class FilesystemImporterStep implements BackendStep
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    List<QRecord> parseFileIntoRecords(RunBackendStepInput runBackendStepInput, String content) throws QException
    {
       /////////////////////////////////////////////////////////////////////////////////////////////////////////

qqq-backend-module-mongodb/src/main/java/com/kingsrook/qqq/backend/module/mongodb/actions/AbstractMongoDBAction.java

@@ -528,7 +528,6 @@ public class AbstractMongoDBAction
    /*******************************************************************************
     ** w/o considering security, just map a QQueryFilter to a Bson searchQuery.
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:Indentation")
    private Bson makeSearchQueryDocumentWithoutSecurity(QTableMetaData table, QQueryFilter filter)
    {
       if(filter == null || !filter.hasAnyCriteria())

qqq-backend-module-mongodb/src/main/java/com/kingsrook/qqq/backend/module/mongodb/actions/MongoDBAggregateAction.java

@@ -70,7 +70,6 @@ public class MongoDBAggregateAction extends AbstractMongoDBAction implements Agg
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    public AggregateOutput execute(AggregateInput aggregateInput) throws QException
    {
       MongoClientContainer mongoClientContainer = null;

qqq-middleware-api/src/main/java/com/kingsrook/qqq/api/actions/GenerateOpenApiSpecAction.java

@@ -1027,7 +1027,6 @@ public class GenerateOpenApiSpecAction extends AbstractQActionFunction<GenerateO
       responses.putAll(buildStandardErrorResponses(apiInstanceMetaData));
       methodForProcess.withResponses(responses);
 
-      @SuppressWarnings("checkstyle:indentation")
       Path path = switch(apiProcessMetaData.getMethod())
       {
          case GET -> new Path().withGet(methodForProcess);
@@ -1555,7 +1554,6 @@ public class GenerateOpenApiSpecAction extends AbstractQActionFunction<GenerateO
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    private Response buildMultiStatusResponse(String tableLabel, String primaryKeyApiName, QFieldMetaData primaryKeyField, String method)
    {
       List<Object> example = switch(method.toLowerCase())
@@ -1713,7 +1711,6 @@ public class GenerateOpenApiSpecAction extends AbstractQActionFunction<GenerateO
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    private static String getFieldType(QFieldType type)
    {
       return switch(type)
@@ -1740,7 +1737,6 @@ public class GenerateOpenApiSpecAction extends AbstractQActionFunction<GenerateO
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    private String getFieldFormat(QFieldType type)
    {
       return switch(type)

qqq-middleware-api/src/main/java/com/kingsrook/qqq/api/javalin/QJavalinApiHandler.java

@@ -298,7 +298,6 @@ public class QJavalinApiHandler
    /*******************************************************************************
     **
     *******************************************************************************/
-   @SuppressWarnings("checkstyle:indentation")
    private void runProcess(Context context, QProcessMetaData processMetaData, ApiProcessMetaData apiProcessMetaData, ApiInstanceMetaData apiInstanceMetaData)
    {
       String version = context.pathParam("version");

qqq-middleware-api/src/main/java/com/kingsrook/qqq/api/model/metadata/processes/ApiProcessSummaryListOutput.java

@@ -233,7 +233,6 @@ public class ApiProcessSummaryListOutput implements ApiProcessOutputInterface
     *******************************************************************************/
    private static String getResultMapMessagePrefix(ProcessSummaryLineInterface processSummaryLine)
    {
-      @SuppressWarnings("checkstyle:indentation")
       String messagePrefix = switch(processSummaryLine.getStatus())
       {
          case OK, INFO, ERROR -> "";
@@ -251,7 +250,6 @@ public class ApiProcessSummaryListOutput implements ApiProcessOutputInterface
    {
       HashMap<String, Serializable> map = new HashMap<>();
 
-      @SuppressWarnings("checkstyle:indentation")
       HttpStatus.Code code = switch(processSummaryLine.getStatus())
       {
          case OK, WARNING, INFO -> HttpStatus.Code.OK;