CE-1955 Checkstyle!

This commit is contained in:
2024-11-12 09:48:02 -06:00
parent e809c773f9
commit 5f081fce44
2 changed files with 23 additions and 23 deletions

View File

@ -167,9 +167,9 @@ class TallRowsToRecordTest extends BaseTest
@Test @Test
void testOrderLinesWithLineExtrinsicsAndOrderExtrinsic() throws QException void testOrderLinesWithLineExtrinsicsAndOrderExtrinsic() throws QException
{ {
Integer DEFAULT_STORE_ID = 101; Integer defaultStoreId = 101;
Integer DEFAULT_LINE_NO = 102; Integer defaultLineNo = 102;
String DEFAULT_ORDER_LINE_EXTRA_SOURCE = "file"; String defaultOrderLineExtraSource = "file";
CsvFileToRows fileToRows = CsvFileToRows.forString(""" CsvFileToRows fileToRows = CsvFileToRows.forString("""
orderNo, Ship To, lastName, SKU, Quantity, Extrinsic Key, Extrinsic Value, Line Extrinsic Key, Line Extrinsic Value orderNo, Ship To, lastName, SKU, Quantity, Extrinsic Key, Extrinsic Value, Line Extrinsic Key, Line Extrinsic Value
@ -197,9 +197,9 @@ class TallRowsToRecordTest extends BaseTest
"orderLine.extrinsics.value", "Line Extrinsic Value" "orderLine.extrinsics.value", "Line Extrinsic Value"
)) ))
.withFieldNameToDefaultValueMap(Map.of( .withFieldNameToDefaultValueMap(Map.of(
"storeId", DEFAULT_STORE_ID, "storeId", defaultStoreId,
"orderLine.lineNumber", DEFAULT_LINE_NO, "orderLine.lineNumber", defaultLineNo,
"orderLine.extrinsics.source", DEFAULT_ORDER_LINE_EXTRA_SOURCE "orderLine.extrinsics.source", defaultOrderLineExtraSource
)) ))
.withFieldNameToValueMapping(Map.of("orderLine.sku", Map.of("DONUT", "D'OH-NUT"))) .withFieldNameToValueMapping(Map.of("orderLine.sku", Map.of("DONUT", "D'OH-NUT")))
.withTallLayoutGroupByIndexMap(Map.of( .withTallLayoutGroupByIndexMap(Map.of(
@ -219,17 +219,17 @@ class TallRowsToRecordTest extends BaseTest
QRecord order = records.get(0); QRecord order = records.get(0);
assertEquals(1, order.getValueInteger("orderNo")); assertEquals(1, order.getValueInteger("orderNo"));
assertEquals("Homer", order.getValueString("shipToName")); assertEquals("Homer", order.getValueString("shipToName"));
assertEquals(DEFAULT_STORE_ID, order.getValue("storeId")); assertEquals(defaultStoreId, order.getValue("storeId"));
assertEquals(List.of("D'OH-NUT", "BEER", "COUCH"), getValues(order.getAssociatedRecords().get("orderLine"), "sku")); assertEquals(List.of("D'OH-NUT", "BEER", "COUCH"), getValues(order.getAssociatedRecords().get("orderLine"), "sku"));
assertEquals(List.of("12", "500", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity")); assertEquals(List.of("12", "500", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity"));
assertEquals(List.of(DEFAULT_LINE_NO, DEFAULT_LINE_NO, DEFAULT_LINE_NO), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber")); assertEquals(List.of(defaultLineNo, defaultLineNo, defaultLineNo), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber"));
assertEquals(List.of("Store Name", "Coupon Code"), getValues(order.getAssociatedRecords().get("extrinsics"), "key")); assertEquals(List.of("Store Name", "Coupon Code"), getValues(order.getAssociatedRecords().get("extrinsics"), "key"));
assertEquals(List.of("QQQ Mart", "10QOff"), getValues(order.getAssociatedRecords().get("extrinsics"), "value")); assertEquals(List.of("QQQ Mart", "10QOff"), getValues(order.getAssociatedRecords().get("extrinsics"), "value"));
QRecord lineItem = order.getAssociatedRecords().get("orderLine").get(0); QRecord lineItem = order.getAssociatedRecords().get("orderLine").get(0);
assertEquals(List.of("Flavor", "Size"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key")); assertEquals(List.of("Flavor", "Size"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key"));
assertEquals(List.of("Chocolate", "Large"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "value")); assertEquals(List.of("Chocolate", "Large"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "value"));
assertEquals(List.of(DEFAULT_ORDER_LINE_EXTRA_SOURCE, DEFAULT_ORDER_LINE_EXTRA_SOURCE), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "source")); assertEquals(List.of(defaultOrderLineExtraSource, defaultOrderLineExtraSource), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "source"));
lineItem = order.getAssociatedRecords().get("orderLine").get(1); lineItem = order.getAssociatedRecords().get("orderLine").get(1);
assertEquals(List.of("Flavor"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key")); assertEquals(List.of("Flavor"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key"));
@ -238,16 +238,16 @@ class TallRowsToRecordTest extends BaseTest
order = records.get(1); order = records.get(1);
assertEquals(2, order.getValueInteger("orderNo")); assertEquals(2, order.getValueInteger("orderNo"));
assertEquals("Ned", order.getValueString("shipToName")); assertEquals("Ned", order.getValueString("shipToName"));
assertEquals(DEFAULT_STORE_ID, order.getValue("storeId")); assertEquals(defaultStoreId, order.getValue("storeId"));
assertEquals(List.of("BIBLE", "LAWNMOWER"), getValues(order.getAssociatedRecords().get("orderLine"), "sku")); assertEquals(List.of("BIBLE", "LAWNMOWER"), getValues(order.getAssociatedRecords().get("orderLine"), "sku"));
assertEquals(List.of("7", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity")); assertEquals(List.of("7", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity"));
assertEquals(List.of(DEFAULT_LINE_NO, DEFAULT_LINE_NO), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber")); assertEquals(List.of(defaultLineNo, defaultLineNo), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber"));
assertThat(order.getAssociatedRecords().get("extrinsics")).isNullOrEmpty(); assertThat(order.getAssociatedRecords().get("extrinsics")).isNullOrEmpty();
lineItem = order.getAssociatedRecords().get("orderLine").get(0); lineItem = order.getAssociatedRecords().get("orderLine").get(0);
assertEquals(List.of("Flavor"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key")); assertEquals(List.of("Flavor"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key"));
assertEquals(List.of("King James"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "value")); assertEquals(List.of("King James"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "value"));
assertEquals(List.of(DEFAULT_ORDER_LINE_EXTRA_SOURCE), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "source")); assertEquals(List.of(defaultOrderLineExtraSource), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "source"));
} }

View File

@ -222,9 +222,9 @@ class WideRowsToRecordTest extends BaseTest
***************************************************************************/ ***************************************************************************/
private void testOrderLinesWithLineExtrinsicsAndOrderExtrinsic(String csv) throws QException private void testOrderLinesWithLineExtrinsicsAndOrderExtrinsic(String csv) throws QException
{ {
Integer DEFAULT_STORE_ID = 42; Integer defaultStoreId = 42;
Integer DEFAULT_LINE_NO = 47; Integer defaultLineNo = 47;
String DEFAULT_LINE_EXTRA_VALUE = "bar"; String defaultLineExtraValue = "bar";
CsvFileToRows fileToRows = CsvFileToRows.forString(csv); CsvFileToRows fileToRows = CsvFileToRows.forString(csv);
BulkLoadFileRow header = fileToRows.next(); BulkLoadFileRow header = fileToRows.next();
@ -245,9 +245,9 @@ class WideRowsToRecordTest extends BaseTest
.withMappedAssociations(List.of("orderLine", "extrinsics", "orderLine.extrinsics")) .withMappedAssociations(List.of("orderLine", "extrinsics", "orderLine.extrinsics"))
.withFieldNameToValueMapping(Map.of("orderLine.extrinsics.value", Map.of("Large", "L", "X-Large", "XL"))) .withFieldNameToValueMapping(Map.of("orderLine.extrinsics.value", Map.of("Large", "L", "X-Large", "XL")))
.withFieldNameToDefaultValueMap(Map.of( .withFieldNameToDefaultValueMap(Map.of(
"storeId", DEFAULT_STORE_ID, "storeId", defaultStoreId,
"orderLine.lineNumber", DEFAULT_LINE_NO, "orderLine.lineNumber", defaultLineNo,
"orderLine.extrinsics.value", DEFAULT_LINE_EXTRA_VALUE "orderLine.extrinsics.value", defaultLineExtraValue
)) ))
.withTableName(TestUtils.TABLE_NAME_ORDER) .withTableName(TestUtils.TABLE_NAME_ORDER)
.withLayout(BulkInsertMapping.Layout.WIDE) .withLayout(BulkInsertMapping.Layout.WIDE)
@ -259,10 +259,10 @@ class WideRowsToRecordTest extends BaseTest
QRecord order = records.get(0); QRecord order = records.get(0);
assertEquals(1, order.getValueInteger("orderNo")); assertEquals(1, order.getValueInteger("orderNo"));
assertEquals("Homer", order.getValueString("shipToName")); assertEquals("Homer", order.getValueString("shipToName"));
assertEquals(DEFAULT_STORE_ID, order.getValue("storeId")); assertEquals(defaultStoreId, order.getValue("storeId"));
assertEquals(List.of("DONUT", "BEER", "COUCH"), getValues(order.getAssociatedRecords().get("orderLine"), "sku")); assertEquals(List.of("DONUT", "BEER", "COUCH"), getValues(order.getAssociatedRecords().get("orderLine"), "sku"));
assertEquals(List.of("12", "500", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity")); assertEquals(List.of("12", "500", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity"));
assertEquals(List.of(DEFAULT_LINE_NO, DEFAULT_LINE_NO, DEFAULT_LINE_NO), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber")); assertEquals(List.of(defaultLineNo, defaultLineNo, defaultLineNo), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber"));
assertEquals(List.of("Store Name", "Coupon Code"), getValues(order.getAssociatedRecords().get("extrinsics"), "key")); assertEquals(List.of("Store Name", "Coupon Code"), getValues(order.getAssociatedRecords().get("extrinsics"), "key"));
assertEquals(List.of("QQQ Mart", "10QOff"), getValues(order.getAssociatedRecords().get("extrinsics"), "value")); assertEquals(List.of("QQQ Mart", "10QOff"), getValues(order.getAssociatedRecords().get("extrinsics"), "value"));
@ -276,15 +276,15 @@ class WideRowsToRecordTest extends BaseTest
lineItem = order.getAssociatedRecords().get("orderLine").get(2); lineItem = order.getAssociatedRecords().get("orderLine").get(2);
assertEquals(List.of("Color", "foo"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key")); assertEquals(List.of("Color", "foo"), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "key"));
assertEquals(List.of("Brown", DEFAULT_LINE_EXTRA_VALUE), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "value")); assertEquals(List.of("Brown", defaultLineExtraValue), getValues(lineItem.getAssociatedRecords().get("extrinsics"), "value"));
order = records.get(1); order = records.get(1);
assertEquals(2, order.getValueInteger("orderNo")); assertEquals(2, order.getValueInteger("orderNo"));
assertEquals("Ned", order.getValueString("shipToName")); assertEquals("Ned", order.getValueString("shipToName"));
assertEquals(DEFAULT_STORE_ID, order.getValue("storeId")); assertEquals(defaultStoreId, order.getValue("storeId"));
assertEquals(List.of("BIBLE", "LAWNMOWER"), getValues(order.getAssociatedRecords().get("orderLine"), "sku")); assertEquals(List.of("BIBLE", "LAWNMOWER"), getValues(order.getAssociatedRecords().get("orderLine"), "sku"));
assertEquals(List.of("7", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity")); assertEquals(List.of("7", "1"), getValues(order.getAssociatedRecords().get("orderLine"), "quantity"));
assertEquals(List.of(DEFAULT_LINE_NO, DEFAULT_LINE_NO), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber")); assertEquals(List.of(defaultLineNo, defaultLineNo), getValues(order.getAssociatedRecords().get("orderLine"), "lineNumber"));
assertThat(order.getAssociatedRecords().get("extrinsics")).isNullOrEmpty(); assertThat(order.getAssociatedRecords().get("extrinsics")).isNullOrEmpty();
lineItem = order.getAssociatedRecords().get("orderLine").get(0); lineItem = order.getAssociatedRecords().get("orderLine").get(0);