From 570f4a3f3464bac9ed409e6e715eb35bce129321 Mon Sep 17 00:00:00 2001
From: Darin Kelkhoff <darin.kelkhoff@gmail.com>
Date: Mon, 20 Jun 2022 08:28:20 -0500
Subject: [PATCH] QQQ-14 Checkstyle cleanup

---
 checkstyle.xml                                |  4 ++-
 .../model/metadata/QTableBackendDetails.java  | 28 +++++++++----------
 .../serialization/DeserializerUtils.java      | 10 +++----
 .../core/modules/mock/MockQueryAction.java    |  1 +
 4 files changed, 23 insertions(+), 20 deletions(-)

diff --git a/checkstyle.xml b/checkstyle.xml
index dbaa3479..76f872ed 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -46,6 +46,7 @@
    -->
 
    <module name="TreeWalker">
+      <module name="SuppressWarningsHolder"/>
       <module name="OuterTypeFilename"/>
       <module name="IllegalTokenText">
          <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
@@ -171,7 +172,7 @@
          <property name="caseIndent" value="3"/>
          <property name="throwsIndent" value="6"/>
          <property name="lineWrappingIndentation" value="3"/>
-         <property name="arrayInitIndent" value="2"/>
+         <property name="arrayInitIndent" value="6"/>
       </module>
       <!--
       <module name="AbbreviationAsWordInName">
@@ -260,4 +261,5 @@
       <module name="MissingOverride"/>
 
    </module>
+   <module name="SuppressWarningsFilter"/>
 </module>
diff --git a/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/QTableBackendDetails.java b/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/QTableBackendDetails.java
index 01943bfc..5e78da9d 100644
--- a/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/QTableBackendDetails.java
+++ b/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/QTableBackendDetails.java
@@ -59,18 +59,6 @@ public abstract class QTableBackendDetails
 
 
 
-   /*******************************************************************************
-    ** Fluent Setter for backendType
-    **
-    *******************************************************************************/
-   public QTableBackendDetails withBackendType(String backendType)
-   {
-      this.backendType = backendType;
-      return (this);
-   }
-
-
-
    /*******************************************************************************
     ** Setter for backendType
     **
@@ -88,6 +76,20 @@ public abstract class QTableBackendDetails
       }
    }
 
+
+
+   /*******************************************************************************
+    ** Fluent Setter for backendType
+    **
+    *******************************************************************************/
+   public QTableBackendDetails withBackendType(String backendType)
+   {
+      this.backendType = backendType;
+      return (this);
+   }
+
+
+
    /*******************************************************************************
     ** Fluent Setter for backendType
     **
@@ -98,6 +100,4 @@ public abstract class QTableBackendDetails
       return (this);
    }
 
-
-
 }
diff --git a/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/serialization/DeserializerUtils.java b/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/serialization/DeserializerUtils.java
index 109a8255..aa36937b 100644
--- a/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/serialization/DeserializerUtils.java
+++ b/src/main/java/com/kingsrook/qqq/backend/core/model/metadata/serialization/DeserializerUtils.java
@@ -81,15 +81,15 @@ public class DeserializerUtils
    /*******************************************************************************
     **
     *******************************************************************************/
-   public static <T> T reflectivelyDeserialize(Class<T> _class, TreeNode treeNode) throws IOException
+   public static <T> T reflectivelyDeserialize(Class<T> outputClass, TreeNode treeNode) throws IOException
    {
       try
       {
-         T output = _class.getConstructor().newInstance();
-         System.out.println("Reflectively deserializing a: " + _class.getName());
+         T output = outputClass.getConstructor().newInstance();
+         System.out.println("Reflectively deserializing a: " + outputClass.getName());
 
          Map<String, Consumer<String>> setterMap = new HashMap<>();
-         for(Method method : _class.getMethods())
+         for(Method method : outputClass.getMethods())
          {
             if(method.getName().startsWith("set") && method.getParameterTypes().length == 1)
             {
@@ -131,7 +131,7 @@ public class DeserializerUtils
                         ////////////////////////////////////////////////////////////////////////
                         // if we hit this, we might want to add an else-if to handle the type //
                         ////////////////////////////////////////////////////////////////////////
-                        throw (new RuntimeException("Field " + fieldName + " is of an unhandled type " + parameterType.getName() + " when deserializing " + _class.getName()));
+                        throw (new RuntimeException("Field " + fieldName + " is of an unhandled type " + parameterType.getName() + " when deserializing " + outputClass.getName()));
                      }
                      else
                      {
diff --git a/src/main/java/com/kingsrook/qqq/backend/core/modules/mock/MockQueryAction.java b/src/main/java/com/kingsrook/qqq/backend/core/modules/mock/MockQueryAction.java
index 6a0b7216..b9475010 100644
--- a/src/main/java/com/kingsrook/qqq/backend/core/modules/mock/MockQueryAction.java
+++ b/src/main/java/com/kingsrook/qqq/backend/core/modules/mock/MockQueryAction.java
@@ -82,6 +82,7 @@ public class MockQueryAction implements QueryInterface
     ** Get a mock value to use, based on its type.
     **
     *******************************************************************************/
+   @SuppressWarnings("checkstyle:MagicNumber")
    private Serializable getValue(QTableMetaData table, String field)
    {
       // @formatter:off // IJ can't do new-style switch correctly yet...