QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-18 13:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

open all connections inside try-with-resources

Browse Source
This commit is contained in:
darin.kelkhoff
2022-07-01 14:54:03 -05:00
parent 5c6ea4732a
commit 55b5f3536c
4 changed files with 96 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSDeleteAction.java
View File

@ -65,7 +65,8 @@ public class RDBMSDeleteAction extends AbstractRDBMSAction implements DeleteInte
// todo sql customization - can edit sql and/or param list
Connection connection = getConnection(deleteRequest);
try(Connection connection = getConnection(deleteRequest))
{
QueryManager.executeUpdateForRowCount(connection, sql, params);
List<QRecord> outputRecords = new ArrayList<>();
rs.setRecords(outputRecords);
@ -76,6 +77,7 @@ public class RDBMSDeleteAction extends AbstractRDBMSAction implements DeleteInte
QRecord outputRecord = new QRecord(qRecord);
outputRecords.add(outputRecord);
}
}
return rs;
}

4
src/main/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSInsertAction.java
View File

@ -99,7 +99,8 @@ public class RDBMSInsertAction extends AbstractRDBMSAction implements InsertInte
// todo - non-serial-id style tables
// todo - other generated values, e.g., createDate... maybe need to re-select?
Connection connection = getConnection(insertRequest);
try(Connection connection = getConnection(insertRequest))
{
List<Integer> idList = QueryManager.executeInsertForGeneratedIds(connection, sql.toString(), params);
List<QRecord> outputRecords = new ArrayList<>();
rs.setRecords(outputRecords);
@ -111,6 +112,7 @@ public class RDBMSInsertAction extends AbstractRDBMSAction implements InsertInte
outputRecord.setValue(table.getPrimaryKeyField(), id);
outputRecords.add(outputRecord);
}
}
return rs;
}

6
src/main/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSQueryAction.java
View File

@ -56,6 +56,8 @@ public class RDBMSQueryAction extends AbstractRDBMSAction implements QueryInterf
{
private static final Logger LOG = LogManager.getLogger(RDBMSQueryAction.class);
/*******************************************************************************
**
*******************************************************************************/
@ -102,7 +104,8 @@ public class RDBMSQueryAction extends AbstractRDBMSAction implements QueryInterf
List<QRecord> records = new ArrayList<>();
rs.setRecords(records);
Connection connection = getConnection(queryRequest);
try(Connection connection = getConnection(queryRequest))
{
QueryManager.executeStatement(connection, sql, ((ResultSet resultSet) ->
{
ResultSetMetaData metaData = resultSet.getMetaData();
@ -125,6 +128,7 @@ public class RDBMSQueryAction extends AbstractRDBMSAction implements QueryInterf
}
}), params);
}
return rs;
}

4
src/main/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSUpdateAction.java
View File

@ -58,7 +58,8 @@ public class RDBMSUpdateAction extends AbstractRDBMSAction implements UpdateInte
// todo - sql batch for performance
// todo - if setting a bunch of records to have the same value, a single update where id IN?
Connection connection = getConnection(updateRequest);
try(Connection connection = getConnection(updateRequest))
{
int recordIndex = 0;
for(QRecord record : updateRequest.getRecords())
{
@ -101,6 +102,7 @@ public class RDBMSUpdateAction extends AbstractRDBMSAction implements UpdateInte
throw new QException("Error executing update: " + e.getMessage(), e);
}
}
}
return rs;
}