QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-18 13:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add log info for committing of slow transactions

Browse Source
This commit is contained in:
darin.kelkhoff
2023-05-18 09:49:57 -05:00
parent c0237e9d09
commit 46afb46910
1 changed files with 36 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
qqq-backend-module-rdbms/src/main/java/com/kingsrook/qqq/backend/module/rdbms/actions/RDBMSTransaction.java
View File

@ -24,9 +24,12 @@ package com.kingsrook.qqq.backend.module.rdbms.actions;
import java.sql.Connection; import java.sql.Connection;
import java.sql.SQLException; import java.sql.SQLException;
import java.time.Duration;
import java.time.Instant;
import com.kingsrook.qqq.backend.core.actions.QBackendTransaction; import com.kingsrook.qqq.backend.core.actions.QBackendTransaction;
import com.kingsrook.qqq.backend.core.exceptions.QException; import com.kingsrook.qqq.backend.core.exceptions.QException;
import com.kingsrook.qqq.backend.core.logging.QLogger; import com.kingsrook.qqq.backend.core.logging.QLogger;
import static com.kingsrook.qqq.backend.core.logging.LogUtils.logPair;
/******************************************************************************* /*******************************************************************************
@ -40,6 +43,9 @@ public class RDBMSTransaction extends QBackendTransaction
private Connection connection; private Connection connection;
private Instant openedAt = Instant.now();
private Integer logSlowTransactionSeconds = null;
/******************************************************************************* /*******************************************************************************
@ -48,6 +54,17 @@ public class RDBMSTransaction extends QBackendTransaction
public RDBMSTransaction(Connection connection) throws SQLException public RDBMSTransaction(Connection connection) throws SQLException
{ {
connection.setAutoCommit(false); connection.setAutoCommit(false);
String propertyName = "qqq.rdbms.logSlowTransactionSeconds";
try
{
logSlowTransactionSeconds = Integer.parseInt(System.getProperty(propertyName, "10"));
}
catch(Exception e)
{
LOG.debug("Error reading property [" + propertyName + "] value as integer", e);
}
this.connection = connection; this.connection = connection;
} }
@ -72,7 +89,18 @@ public class RDBMSTransaction extends QBackendTransaction
{ {
try try
{ {
LOG.debug("Committing transaction"); Instant commitAt = Instant.now();
Duration duration = Duration.between(openedAt, commitAt);
if(logSlowTransactionSeconds != null && duration.compareTo(Duration.ofSeconds(logSlowTransactionSeconds)) > 0)
{
LOG.info("Committing long-running transaction", logPair("durationSeconds", duration.getSeconds()));
}
else
{
LOG.debug("Committing transaction");
}
connection.commit(); connection.commit();
LOG.debug("Commit complete"); LOG.debug("Commit complete");
} }
@ -81,6 +109,13 @@ public class RDBMSTransaction extends QBackendTransaction
LOG.error("Error committing transaction", e); LOG.error("Error committing transaction", e);
throw new QException("Error committing transaction: " + e.getMessage(), e); throw new QException("Error committing transaction: " + e.getMessage(), e);
} }
finally
{
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// reset this - as after one commit, the transaction is essentially re-opened for any future statements that run on it //
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
openedAt = Instant.now();
}
} }