CTLE-421: fixes for failing tests, removed no longer necessary loop

This commit is contained in:
Tim Chamberlain
2023-04-28 13:59:08 -05:00
parent b0d0de5d49
commit 2832566dbd

View File

@ -377,7 +377,7 @@ public class GetAction
if(getInput.getShouldOmitHiddenFields() || getInput.getShouldMaskPasswords()) if(getInput.getShouldOmitHiddenFields() || getInput.getShouldMaskPasswords())
{ {
Map<String, QFieldMetaData> fields = QContext.getQInstance().getTable(record.getTableName()).getFields(); Map<String, QFieldMetaData> fields = QContext.getQInstance().getTable(getInput.getTableName()).getFields();
for(String fieldName : fields.keySet()) for(String fieldName : fields.keySet())
{ {
QFieldType fieldType = fields.get(fieldName).getType(); QFieldType fieldType = fields.get(fieldName).getType();
@ -398,30 +398,6 @@ public class GetAction
QValueFormatter.setDisplayValuesInRecords(getInput.getTable(), List.of(returnRecord)); QValueFormatter.setDisplayValuesInRecords(getInput.getTable(), List.of(returnRecord));
} }
//////////////////////////////
// mask any password fields //
//////////////////////////////
Map<String, QFieldMetaData> fields = QContext.getQInstance().getTable(record.getTableName()).getFields();
for(String fieldName : fields.keySet())
{
QFieldMetaData field = fields.get(fieldName);
if(getInput.getShouldOmitHiddenFields())
{
if(field.getIsHidden())
{
returnRecord.removeValue(fieldName);
}
}
else if(getInput.getShouldMaskPasswords())
{
if(field.getType() != null && field.getType().needsMasked())
{
returnRecord.setValue(fieldName, "************");
returnRecord.setDisplayValue(fieldName, "************");
}
}
}
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
// note - shouldFetchHeavyFields should be handled by the underlying action // // note - shouldFetchHeavyFields should be handled by the underlying action //
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////