CE-779: updated all addHeader calls to setHeader to avoid duplicate entries

This commit is contained in:
Tim Chamberlain
2024-02-01 11:13:30 -06:00
parent 00a5b72bf3
commit 2681d66b32

View File

@ -715,11 +715,11 @@ public class BaseAPIActionUtil
if(backendMetaData.getAuthorizationType().equals(AuthorizationType.BASIC_AUTH_USERNAME_PASSWORD)) if(backendMetaData.getAuthorizationType().equals(AuthorizationType.BASIC_AUTH_USERNAME_PASSWORD))
{ {
request.addHeader("Authorization", getBasicAuthenticationHeader(record.getValueString(backendMetaData.getVariantOptionsTableUsernameField()), record.getValueString(backendMetaData.getVariantOptionsTablePasswordField()))); request.setHeader("Authorization", getBasicAuthenticationHeader(record.getValueString(backendMetaData.getVariantOptionsTableUsernameField()), record.getValueString(backendMetaData.getVariantOptionsTablePasswordField())));
} }
else if(backendMetaData.getAuthorizationType().equals(AuthorizationType.API_KEY_HEADER)) else if(backendMetaData.getAuthorizationType().equals(AuthorizationType.API_KEY_HEADER))
{ {
request.addHeader("API-Key", record.getValueString(backendMetaData.getVariantOptionsTableApiKeyField())); request.setHeader("API-Key", record.getValueString(backendMetaData.getVariantOptionsTableApiKeyField()));
} }
else else
{ {
@ -733,10 +733,10 @@ public class BaseAPIActionUtil
/////////////////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////////////////
switch(backendMetaData.getAuthorizationType()) switch(backendMetaData.getAuthorizationType())
{ {
case BASIC_AUTH_API_KEY -> request.addHeader("Authorization", getBasicAuthenticationHeader(backendMetaData.getApiKey())); case BASIC_AUTH_API_KEY -> request.setHeader("Authorization", getBasicAuthenticationHeader(backendMetaData.getApiKey()));
case BASIC_AUTH_USERNAME_PASSWORD -> request.addHeader("Authorization", getBasicAuthenticationHeader(backendMetaData.getUsername(), backendMetaData.getPassword())); case BASIC_AUTH_USERNAME_PASSWORD -> request.setHeader("Authorization", getBasicAuthenticationHeader(backendMetaData.getUsername(), backendMetaData.getPassword()));
case API_KEY_HEADER -> request.addHeader("API-Key", backendMetaData.getApiKey()); case API_KEY_HEADER -> request.setHeader("API-Key", backendMetaData.getApiKey());
case API_TOKEN -> request.addHeader("Authorization", "Token " + backendMetaData.getApiKey()); case API_TOKEN -> request.setHeader("Authorization", "Token " + backendMetaData.getApiKey());
case OAUTH2 -> request.setHeader("Authorization", "Bearer " + getOAuth2Token()); case OAUTH2 -> request.setHeader("Authorization", "Bearer " + getOAuth2Token());
case API_KEY_QUERY_PARAM -> case API_KEY_QUERY_PARAM ->
{ {
@ -792,9 +792,9 @@ public class BaseAPIActionUtil
if(setCredentialsInHeader) if(setCredentialsInHeader)
{ {
request.addHeader("Authorization", getBasicAuthenticationHeader(backendMetaData.getClientId(), backendMetaData.getClientSecret())); request.setHeader("Authorization", getBasicAuthenticationHeader(backendMetaData.getClientId(), backendMetaData.getClientSecret()));
} }
request.addHeader("Content-Type", "application/x-www-form-urlencoded; charset=utf-8"); request.setHeader("Content-Type", "application/x-www-form-urlencoded; charset=utf-8");
HttpResponse response = executeOAuthTokenRequest(client, request); HttpResponse response = executeOAuthTokenRequest(client, request);
int statusCode = response.getStatusLine().getStatusCode(); int statusCode = response.getStatusLine().getStatusCode();
@ -856,7 +856,7 @@ public class BaseAPIActionUtil
*******************************************************************************/ *******************************************************************************/
protected void setupContentTypeInRequest(HttpRequestBase request) protected void setupContentTypeInRequest(HttpRequestBase request)
{ {
request.addHeader("Content-Type", backendMetaData.getContentType()); request.setHeader("Content-Type", backendMetaData.getContentType());
} }
@ -878,7 +878,7 @@ public class BaseAPIActionUtil
*******************************************************************************/ *******************************************************************************/
public void setupAdditionalHeaders(HttpRequestBase request) public void setupAdditionalHeaders(HttpRequestBase request)
{ {
request.addHeader("Accept", "application/json"); request.setHeader("Accept", "application/json");
} }