QRunIO/qqq
2
0
Fork 0
mirror of https://github.com/Kingsrook/qqq.git synced 2025-07-18 13:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove field-values that had an error in type convertin' or possible-value lookin' up (to avoid downstream errors e.g., in pre-insert customizers)

Browse Source
This commit is contained in:
darin.kelkhoff
2025-01-29 11:18:10 -06:00
parent ccb51be4f9
commit 0635a9128c
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/processes/implementations/bulk/insert/mapping/BulkLoadValueMapper.java
View File

@ -89,6 +89,11 @@ public class BulkLoadValueMapper
Map<String, Map<String, Serializable>> mappingForTable = mapping.getFieldNameToValueMappingForTable(associationNameChain); Map<String, Map<String, Serializable>> mappingForTable = mapping.getFieldNameToValueMappingForTable(associationNameChain);
for(QRecord record : records) for(QRecord record : records)
{ {
/////////////////////////////////////////////////////////////////////////////////////////////////////
// if we remove in the loop, we get ConcurrentModificationException, so track which ones to remove //
/////////////////////////////////////////////////////////////////////////////////////////////////////
Set<String> toRemove = new HashSet<>();
for(Map.Entry<String, Serializable> valueEntry : record.getValues().entrySet()) for(Map.Entry<String, Serializable> valueEntry : record.getValues().entrySet())
{ {
QFieldMetaData field = table.getField(valueEntry.getKey()); QFieldMetaData field = table.getField(valueEntry.getKey());
@ -129,17 +134,24 @@ public class BulkLoadValueMapper
try try
{ {
value = ValueUtils.getValueAsFieldType(type, value); value = ValueUtils.getValueAsFieldType(type, value);
record.setValue(field.getName(), value);
} }
catch(Exception e) catch(Exception e)
{ {
record.addError(new BulkLoadValueTypeError(associationNamePrefixForFields + field.getName(), value, type, tableLabelPrefix + field.getLabel())); record.addError(new BulkLoadValueTypeError(associationNamePrefixForFields + field.getName(), value, type, tableLabelPrefix + field.getLabel()));
toRemove.add(field.getName());
} }
} }
} }
record.setValue(field.getName(), value);
} }
//////////////////////////////////////////////////////////////////////////////////////////
// remove any field values that had an error. //
// otherwise there can be downstream issues (e.g., if say some customizer code tries to //
// build an entity out of a record, and there's a temporal value that can't be parsed. //
//////////////////////////////////////////////////////////////////////////////////////////
toRemove.forEach(record::removeValue);
////////////////////////////////////// //////////////////////////////////////
// recursively process associations // // recursively process associations //
////////////////////////////////////// //////////////////////////////////////
@ -299,6 +311,7 @@ public class BulkLoadValueMapper
else else
{ {
record.addError(new BulkLoadPossibleValueError(associationNamePrefixForFields + field.getName(), value, tableLabelPrefix + field.getLabel())); record.addError(new BulkLoadPossibleValueError(associationNamePrefixForFields + field.getName(), value, tableLabelPrefix + field.getLabel()));
record.removeValue(field.getName());
} }
} }
} }