From 05a7f9d84726e901a85e7d5f301a92d20b99ad96 Mon Sep 17 00:00:00 2001
From: Darin Kelkhoff <darin.kelkhoff@gmail.com>
Date: Fri, 17 Feb 2023 10:25:14 -0600
Subject: [PATCH] Audit cleanups (process names for automations; no audit if no
 fields changed;

---
 .../core/actions/audits/DMLAuditAction.java     | 11 +++++++----
 .../PollingAutomationPerTableRunner.java        | 17 +++++++++++++----
 .../backend/core/scheduler/ScheduleManager.java |  2 ++
 .../core/actions/audits/DMLAuditActionTest.java | 11 +++++++++++
 4 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
index 890e6ec4..557d8346 100644
--- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
+++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditAction.java
@@ -210,12 +210,15 @@ public class DMLAuditAction extends AbstractQActionFunction<DMLAuditInput, DMLAu
                   }
                }
 
-               if(details.isEmpty())
+               if(details.isEmpty() && DMLType.UPDATE.equals(dmlType))
                {
-                  details.add(new QRecord().withValue("message", "No fields values were changed."));
+                  // no, let's just noop.
+                  // details.add(new QRecord().withValue("message", "No fields values were changed."));
+               }
+               else
+               {
+                  AuditAction.appendToInput(auditInput, table.getName(), record.getValueInteger(table.getPrimaryKeyField()), getRecordSecurityKeyValues(table, record), "Record was " + dmlType.pastTenseVerb + contextSuffix, details);
                }
-
-               AuditAction.appendToInput(auditInput, table.getName(), record.getValueInteger(table.getPrimaryKeyField()), getRecordSecurityKeyValues(table, record), "Record was " + dmlType.pastTenseVerb + contextSuffix, details);
             }
          }
 
diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/automation/polling/PollingAutomationPerTableRunner.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/automation/polling/PollingAutomationPerTableRunner.java
index f5b53351..32e948b4 100644
--- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/automation/polling/PollingAutomationPerTableRunner.java
+++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/actions/automation/polling/PollingAutomationPerTableRunner.java
@@ -381,11 +381,20 @@ public class PollingAutomationPerTableRunner implements Runnable
             }
          });
 
-         RunProcessAction runProcessAction = new RunProcessAction();
-         RunProcessOutput runProcessOutput = runProcessAction.execute(runProcessInput);
-         if(runProcessOutput.getException().isPresent())
+         try
          {
-            throw (runProcessOutput.getException().get());
+            QContext.pushAction(runProcessInput);
+
+            RunProcessAction runProcessAction = new RunProcessAction();
+            RunProcessOutput runProcessOutput = runProcessAction.execute(runProcessInput);
+            if(runProcessOutput.getException().isPresent())
+            {
+               throw (runProcessOutput.getException().get());
+            }
+         }
+         finally
+         {
+            QContext.popAction();
          }
       }
       else if(action.getCodeReference() != null)
diff --git a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/scheduler/ScheduleManager.java b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/scheduler/ScheduleManager.java
index bf8a11fa..4bdd250f 100644
--- a/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/scheduler/ScheduleManager.java
+++ b/qqq-backend-core/src/main/java/com/kingsrook/qqq/backend/core/scheduler/ScheduleManager.java
@@ -265,6 +265,8 @@ public class ScheduleManager
             runProcessInput.setProcessName(process.getName());
             runProcessInput.setFrontendStepBehavior(RunProcessInput.FrontendStepBehavior.SKIP);
 
+            QContext.pushAction(runProcessInput);
+
             RunProcessAction runProcessAction = new RunProcessAction();
             runProcessAction.execute(runProcessInput);
          }
diff --git a/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditActionTest.java b/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditActionTest.java
index e46547c1..954c079f 100644
--- a/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditActionTest.java
+++ b/qqq-backend-core/src/test/java/com/kingsrook/qqq/backend/core/actions/audits/DMLAuditActionTest.java
@@ -173,6 +173,17 @@ class DMLAuditActionTest extends BaseTest
          assertTrue(auditDetailList.stream().noneMatch(r -> r.getValueString("message").contains("Favorite Shape")));
          MemoryRecordStore.getInstance().reset();
       }
+
+      ///////////////////////////////////////////////////////////
+      // confirm if nothing changed on an edit, that no audit. //
+      ///////////////////////////////////////////////////////////
+      {
+         qInstance.getTable(TestUtils.TABLE_NAME_PERSON_MEMORY).setAuditRules(new QAuditRules().withAuditLevel(AuditLevel.FIELD));
+         new DMLAuditAction().execute(new DMLAuditInput().withTableActionInput(updateInput).withRecordList(recordList).withOldRecordList(recordList));
+         List<QRecord> auditList = TestUtils.queryTable("audit");
+         assertEquals(0, auditList.size());
+         MemoryRecordStore.getInstance().reset();
+      }
    }
 
 }
\ No newline at end of file