Feedback from code reviews

This commit is contained in:
2022-11-03 10:43:34 -05:00
parent 05af6f2334
commit 82868b9f8d

View File

@ -985,7 +985,6 @@ function EntityList({table, launchProcess}: Props): JSX.Element
// @ts-ignore // @ts-ignore
const defaultLabelDisplayedRows = ({from, to, count}) => const defaultLabelDisplayedRows = ({from, to, count}) =>
{ {
console.log(`In defaultLabelDisplayedRows with ${from} ${to} ${count}`);
if(tableMetaData && !tableMetaData.capabilities.has(Capability.TABLE_COUNT)) if(tableMetaData && !tableMetaData.capabilities.has(Capability.TABLE_COUNT))
{ {
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
@ -1190,7 +1189,7 @@ function EntityList({table, launchProcess}: Props): JSX.Element
Bulk Delete Bulk Delete
</MenuItem> </MenuItem>
} }
{tableProcesses.length > 0 && <Divider />} {(table.capabilities.has(Capability.TABLE_INSERT) || table.capabilities.has(Capability.TABLE_UPDATE) || table.capabilities.has(Capability.TABLE_DELETE)) && tableProcesses.length > 0 && <Divider />}
{tableProcesses.map((process) => ( {tableProcesses.map((process) => (
<MenuItem key={process.name} onClick={() => processClicked(process)}> <MenuItem key={process.name} onClick={() => processClicked(process)}>
<ListItemIcon><Icon>{process.iconName ?? "arrow_forward"}</Icon></ListItemIcon> <ListItemIcon><Icon>{process.iconName ?? "arrow_forward"}</Icon></ListItemIcon>