From 317d687b22779765a2b18e8cc7ba64df0677bfb8 Mon Sep 17 00:00:00 2001 From: Darin Kelkhoff Date: Mon, 3 Jul 2023 11:11:55 -0500 Subject: [PATCH] Fix bug w/ url in query string, w/ value=false (and js false == "") --- src/qqq/utils/qqq/FilterUtils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qqq/utils/qqq/FilterUtils.ts b/src/qqq/utils/qqq/FilterUtils.ts index e599433..a428c2c 100644 --- a/src/qqq/utils/qqq/FilterUtils.ts +++ b/src/qqq/utils/qqq/FilterUtils.ts @@ -699,10 +699,11 @@ class FilterUtils //////////////////////////////////////////////////////////////////////////////// // if no value set and not 'empty' or 'not empty' operators, skip this filter // //////////////////////////////////////////////////////////////////////////////// - if ((!item.value || item.value.length == 0 || (item.value.length == 1 && item.value[0] == "")) && item.operatorValue !== "isEmpty" && item.operatorValue !== "isNotEmpty") + if ((!item.value || item.value.length == 0 || (item.value.length == 1 && (item.value[0] === "" || item.value[0] === undefined))) && item.operatorValue !== "isEmpty" && item.operatorValue !== "isNotEmpty") { if (!allowIncompleteCriteria) { + console.log(`Discarding incomplete filter criteria: ${JSON.stringify(item)}`); return; } }